Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer using Uri.parse instead of Uri.http/Uri.https #5834

Merged
merged 1 commit into from
May 21, 2021
Merged

Prefer using Uri.parse instead of Uri.http/Uri.https #5834

merged 1 commit into from
May 21, 2021

Commits on May 20, 2021

  1. Prefer using Uri.parse instead of Uri.http/Uri.https 

    Using `Uri.http`/`Uri.https` are *much* more error-prone than using
`Uri.parse`, and judging from various StackOverflow questions, quite
a number of people either misunderstand how to use them or would have
avoided their problem by using `Uri.parse`.  Examples:

* https://stackoverflow.com/q/66619895/
* https://stackoverflow.com/a/66608366/
* https://stackoverflow.com/q/67535694/
* https://stackoverflow.com/q/67628555/
* https://stackoverflow.com/q/67451865/

IMO, we should advocate using `Uri.parse` when possible, particularly
in tutorials, where using `Uri.http`/`Uri.https` directly is a
premature optimization.
    @jamesderlin
    jamesderlin committed May 20, 2021
    Configuration menu
    Copy the full SHA
    91a2aac View commit details
    Browse the repository at this point in the history