add VSCode DevContainer #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
|
Will this resolve #112? |
|
yes! Sorry should have put that - let me add to the description. |
|
Yes this was the correct one I think! |
slabasan
reviewed
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
okay - second time is the charm! With @slabasan magic touch, this seemed to work the second time around! This pull request will:
This will close #112
Once we have the automated build for
ghcr.io/flux-framework/perf-flow-aspect-basewe can very easily add one for just"ghcr.io/flux-framework/perf-flow-aspect"The use case is wanting a container, ready to go, to develop your application with PerfFlowAspect.This PR and the subsequent one (I'll open after the container deploys) will subsume #114. With the second container I'll update the developer.rst with another section for how to get started with an example Python app, for example.