autoconf: support python 3.12 #6303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oooh, some neat stuff in here! https://docs.python.org/3/whatsnew/3.12.html |
|
I've set MWP here. Thanks @trws! |
|
Actually this is failing in the alpine builder with: I'll try to take a look at this tonight. |
problem: flux-core currently can't configure with python3.12 due to setuptools no longer being part of the default distribution solution: import setuptools where necessary to keep things working in the ax_python_devel file Also add setuptools as an explicit dep in our scripts and the one dockerfile that lacked it.
|
I managed to test it, adding py3-setuptools looks like it's all we actually need. The other dockerfiles already have it. I pushed the dockerfile, but the internet on the plane is not conducive to actually building and pushing the darned thing to dockerhub. |
I can do this but I can't seem to build docker images anymore (I may need to set up a VM with a newer docker): Note: We need to update the |
|
I think you’re missing the positional argument for the context directory, normally it’s just “.” or whatever the path to the flux core repo base is.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Mark Grondona ***@***.***>
Sent: Friday, September 27, 2024 12:12:13 AM
To: flux-framework/flux-core ***@***.***>
Cc: Scogland, Tom ***@***.***>; Mention ***@***.***>
Subject: Re: [flux-framework/flux-core] autoconf: support python 3.12 (PR #6303)
but the internet on the plane is not conducive to actually building and pushing the darned thing to dockerhub.
I can do this but I can't seem to build docker images anymore (I may need to set up a VM with a newer docker):
$ docker build --no-cache -t fluxrm/testenv:alpine -f src/test/docker/alpine/Dockerfile
ERROR: "docker buildx build" requires exactly 1 argument.
See 'docker buildx build --help'.
Usage: docker buildx build [OPTIONS] PATH | URL | -
Start a build
Note: We need to update the src/test/docker/README.md. Instructions don't work anymore.
—
Reply to this email directly, view it on GitHub<https://urldefense.us/v3/__https://github.com/flux-framework/flux-core/pull/6303*issuecomment-2377096554__;Iw!!G2kpM7uM-TzIFchu!3s_E1xccy9ofLiG_EZyEW9Iw_xTebw9-ATExhTXGOj6eDh6oIraYvaFxi531dxnUob_NNPiba7saNUqxEQtgoN9onkQ$>, or unsubscribe<https://urldefense.us/v3/__https://github.com/notifications/unsubscribe-auth/AAFBFNKMNWZ3AH62PYFYXZLZYQI33AVCNFSM6AAAAABOZ3SS32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZXGA4TMNJVGQ__;!!G2kpM7uM-TzIFchu!3s_E1xccy9ofLiG_EZyEW9Iw_xTebw9-ATExhTXGOj6eDh6oIraYvaFxi531dxnUob_NNPiba7saNUqxEQtg0necWx8$>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
D'oh! That seems to be working. 🤦 |
|
Ok, pushed the alpine image and reran CI and the PR is now merged. Thanks @trws! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6303 +/- ##
==========================================
- Coverage 83.33% 83.32% -0.01%
==========================================
Files 523 523
Lines 86133 86133
==========================================
- Hits 71775 71770 -5
- Misses 14358 14363 +5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: flux-core currently can't configure with python3.12 due to setuptools no longer being part of the default distribution
solution: import setuptools where necessary to keep things working in the ax_python_devel file
This worked to build a copy of flux, but I didn't get the dep install scripts updated yet because I couldn't get an image downloaded on this wifi. Now off to dinner and the airport.