testsuite: add --raw-response opt to rpc test program #6342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! MWP! |
Problem: t/request/rpc adds a NUL character to output. Add a -R,--raw-response option which allows any raw payload to be output when that matters, but otherwise omit the NUL character when the response is a string. Update tests that require raw payloads. Fixes flux-framework#6340
Problem: some tests define $RPC without using it. Drop it in those tests.
Problem t/request/rpc_stream uses flux_rpc_raw() when it doesn't support raw payloads. Use flux_rpc(). Duh.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6342 +/- ##
===========================================
+ Coverage 53.75% 83.33% +29.57%
===========================================
Files 474 523 +49
Lines 78606 86189 +7583
===========================================
+ Hits 42257 71823 +29566
+ Misses 36349 14366 -21983 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
t/request/rpcadds a NUL character to output.Add a
-R,--raw-responseoption which allows any raw payload to be output when that matters, but otherwise omit the NUL character when the response is a string.Update tests that require raw payloads.
Also do a bit of adjacent cleanup.