allow project to be built with NDEBUG #6355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: compiler warnings are issued on message code when the project is built with NDEBUG defined. Remove unhelpful assertions.
Problem: when the kvs is compiled with NDEBUG, warnings are issued for unused variables. Declare those variables with __attribute__((unused)) to silence the warnings.
Problem: compiler warnings are issued on the broker code when the project is built with NDEBUG defined. Convert assertions to runtime errors. Just remove some assertions that are not helpful.
Problem: compiler warnings are issued on the flux-proxy code when the project is built with NDEBUG defined. Convert warnings to runtime errors. In one case, remove an unnecessary assertion.
Problem: AM_CPPFLAGS does not include CODE_COVERAGE_CPPFLAGS, so NDEBUG is not defined when coverage is calculated. Furthermore, this means the code is not compiled with NDEBUG in CI, so we don't notice some unused variable warnings that may come up for end users. Add CODE_COVERAGE_CPPFLAGS to all the AM_CPPFLAGS definitions in our Makefile.am files. Fixes flux-framework#6354
|
Thanks! Setting MWP. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6355 +/- ##
==========================================
- Coverage 83.32% 83.29% -0.04%
==========================================
Files 523 523
Lines 86209 86194 -15
==========================================
- Hits 71836 71795 -41
- Misses 14373 14399 +26
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: as noted in #6354, we get some compiler warnings (promoted to errors) when the project is built with
-DNDEBUG.@grondo pointed out that we missed adding CODE_COVERAGE_CPPFLAGS to our Makefiles, otherwise we would have been building with that flag in CI.
So this PR adds CODE_COVERAGE_CPPFLAGS to AM_CPPFLAGS in all our Makefiles, and then addresses the warnings that result in a way that seemed appropriate for the context, one of:
__attribute__((unused))