testsuite: add test for double-booking #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fedora34 builder apparently did not reproduce the issue - I'm guessing maybe the timing is a little tight:
|
|
Well the 2s epilog I thought I had included was actually not enabled - fixed that. |
garlick
added a commit
to garlick/flux-core
that referenced
this pull request
Jul 5, 2023
Problem: alloc-check test was simplified when it was submitted as flux-framework/flux-sched#1044. Simplify script in a similar way. For sched-simple, reduce the number of jobs submitted from 5 to 3 to expedite testing.
garlick
added a commit
to garlick/flux-core
that referenced
this pull request
Jul 7, 2023
Problem: alloc-check test was simplified when it was submitted as flux-framework/flux-sched#1044. Simplify script in a similar way. For sched-simple, reduce the number of jobs submitted from 5 to 3 to expedite testing.
Problem: there is no test script for ensuring fluxion never allocates the same resources to multiple jobs. Add a sharness script that utilizes the alloc-check plugin to account for allocated resources and catch errors. At this point, it just includes an "expected failure" test for flux-framework#1043.
|
Test commits squashed, and a "skip" added for older flux-core as discused in ☕ time today. |
Codecov Report
@@ Coverage Diff @@
## master #1044 +/- ##
======================================
Coverage 74.3% 74.4%
======================================
Files 86 86
Lines 9432 9432
======================================
+ Hits 7017 7020 +3
+ Misses 2415 2412 -3 |
grondo
approved these changes
Jul 8, 2023
3 tasks
|
Thanks! I'll set MWP. |
garlick
added
the
merge-when-passing
milroy
added a commit
to milroy/flux-sched
that referenced
this pull request
Jul 10, 2023
Problem: flux-framework#1044 introduced tests to check for allocation failures due to jobs that exceed their time limit. PR flux-framework#1044 had to define the two `alloc-check` tests as `test_expect_failure` because the mechanism to prevent multiple booking was not in place. Update the two `alloc-check` tests to test_expect_success since the PR of this commit fixes multiple booking in Fluxion.
milroy
added a commit
to milroy/flux-sched
that referenced
this pull request
Jul 11, 2023
Problem: flux-framework#1044 introduced tests to check for allocation failures due to jobs that exceed their time limit. PR flux-framework#1044 had to define the two `alloc-check` tests as `test_expect_failure` because the mechanism to prevent multiple booking was not in place. Update the two `alloc-check` tests to test_expect_success since the PR of this commit fixes multiple booking in Fluxion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: there is no test script for ensuring fluxion never allocates the same resources to multiple jobs.
Add a sharness script that utilizes the alloc-check plugin to account for allocated resources and catch errors. At this point, it just includes an "expected failure" test for #1043.
Note that this PR requires a version of flux-core with flux-framework/flux-core#5304 (just merged). I wanted to get this posted as I saw that @milroy was looking into #1043.