Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add support for expiration update #1158

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

milroy
Copy link
Member

@milroy milroy commented Mar 27, 2024

This PR adds functionality to update an allocated job's expiration. To do so, we add modify functionality within the traverser to update a jobid rather than remove it. The PR adds functionality to update planner scheduled points to extend the last and last_p->at times. When merged, this PR will resolve issue #1079.

This PR is WIP as it isn't clear whether the simple modification of an allocation's expiration will work when there are queue policies that create reservations.

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Merging #1158 (f15a5f0) into master (68c636a) will decrease coverage by 1.0%.
The diff coverage is 31.7%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1158     +/-   ##
========================================
- Coverage    71.0%   70.1%   -1.0%     
========================================
  Files          96      96             
  Lines       12867   13079    +212     
========================================
+ Hits         9147    9175     +28     
- Misses       3720    3904    +184     
Files Coverage Δ
resource/traversers/dfu_impl.hpp 94.7% <ø> (ø)
resource/planner/c++/planner.cpp 81.9% <0.0%> (-1.6%) ⬇️
resource/traversers/dfu.cpp 83.4% <0.0%> (-4.2%) ⬇️
qmanager/modules/qmanager.cpp 70.6% <70.4%> (-2.9%) ⬇️
resource/planner/c/planner_multi_c_interface.cpp 55.3% <0.0%> (-2.8%) ⬇️
resource/planner/c/planner_c_interface.cpp 66.8% <0.0%> (-3.3%) ⬇️
resource/utilities/command.cpp 71.6% <0.0%> (-3.8%) ⬇️
resource/modules/resource_match.cpp 66.8% <17.3%> (-1.8%) ⬇️
resource/traversers/dfu_impl_update.cpp 70.0% <43.9%> (-7.7%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow expiration of running jobs to be adjusted via sched.expiration RPC
1 participant