Update helm-controller to new unified standards #302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
…ter and setter for HelmRelease Signed-off-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
Keep in for conssitency. I was not aware of this k8s func convention. This reverts commit f27e6f3.
…spacedObjectReference`
hiddeco
reviewed
Jul 22, 2021
| hr.Status.LastAttemptedRevision = revision | ||
| hr.Status.LastReleaseRevision = releaseRevision | ||
| hr.Status.LastAttemptedValuesChecksum = valuesChecksum | ||
| func HelmReleaseAttempted(obj *HelmRelease, revision string, releaseRevision int, valuesChecksum string) bool { |
There was a problem hiding this comment.
I would prefer this to be removed from the API package in the end, as it is more related to the logic of the reconciler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/fluxcd/flux2/issues/1637
Draft PR. More work and context for this description coming.