fix: Retry failed releases when charts are available in storage #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
speed-up-recovery
branch
from
cd8b630
to
bd3ec35
Compare
stefanprodan
changed the title
hiddeco
approved these changes
Oct 4, 2023
stefanprodan
added
bug
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When charts are not available in SC storage (e.g. after a Flux upgrade) all releases fail to reconcile with
HelmChart is not readyand HR status is set toReady=False. The controller would not retry the reconciliation when the chart artifact become available in storage, instead the controller is using the.spec.intervalfor retries which forces users to set low intervals just to cope with upgrades. This PR changes the chart watcher to trigger a reconciliation for failed releases the moment charts become ready.