Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSTeams certificates #257

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Fix MSTeams certificates #257

merged 2 commits into from
Oct 22, 2021

Conversation

phillebaba
Copy link
Member

This adds support for self signed certs in the MS Teams provider.

Fixes #247

Signed-off-by: Philip Laine <philip.laine@gmail.com>
Signed-off-by: Philip Laine <philip.laine@xenit.se>
@stefanprodan
Copy link
Member

@phillebaba you need to remove all the Go 1.17 annotations, or downgrade Go on your machine and regenerate the files.

Signed-off-by: Philip Laine <philip.laine@xenit.se>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @phillebaba please squash and force push.

@phillebaba phillebaba merged commit 3a43759 into main Oct 22, 2021
@phillebaba phillebaba deleted the feature/msteams-cert-pool branch October 22, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x509: certificate signed by unknown authority error while sending notification to Teams
2 participants