Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic auth support to grafana provider #334

Merged

Conversation

fsequeira1
Copy link
Contributor

@fsequeira1 fsequeira1 commented Feb 21, 2022

Fix: #332
Signed-off-by: Filipe Sequeira filipe@weave.works

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new lines at the end of files: grafana.go, grafana_test.go, utils.go and utils_test.go.

Signed-off-by: Filipe Sequeira <filipe@weave.works>
@fsequeira1 fsequeira1 force-pushed the add-basic-auth-to-grafana-provider branch from ce2ba39 to c904061 Compare February 21, 2022 12:38
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @fsequeira1

@stefanprodan stefanprodan added area/alerting Alerting related issues and PRs enhancement New feature or request labels Feb 22, 2022
@stefanprodan stefanprodan merged commit 348a815 into fluxcd:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Alerting related issues and PRs enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow using Basic Auth in Grafana provider
2 participants