Fix context cancel defer for commit status updates #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
fix/context
branch
from
19660dc
to
8c0817c
Compare
phillebaba
force-pushed
the
fix/context
branch
from
8c0817c
to
1857158
Compare
phillebaba
force-pushed
the
fix/context
branch
2 times, most recently
from
b4e094a
to
a9b47e5
Compare
Signed-off-by: Philip Laine <philip.laine@gmail.com>
phillebaba
force-pushed
the
fix/context
branch
from
a9b47e5
to
82253a9
Compare
stefanprodan
changed the title
stefanprodan
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the cancel defer so that it is not cancelled before the go routine can run. The issue right now is that the Post function is cancelled prematurely.
Fixes #406