Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect namespaced objects without a namespace specified #716

Closed
Tracked by #4556
stefanprodan opened this issue Jan 16, 2024 · 0 comments · Fixed by #720
Closed
Tracked by #4556

Detect namespaced objects without a namespace specified #716

stefanprodan opened this issue Jan 16, 2024 · 0 comments · Fixed by #720
Labels
area/server-side-apply SSA related issues and pull requests bug Something isn't working help wanted Extra attention is needed

Comments

@stefanprodan
Copy link
Member

In the latest refactoring of SSA we have removed the namespace is not specified hint from the returned error. For resourced failing with not found we should determine if it's a namespaced object and if metadata.namespace is missing wrap the retuned error with namespace is not specified.
@stefanprodan stefanprodan added bug Something isn't working area/server-side-apply SSA related issues and pull requests help wanted Extra attention is needed labels Jan 16, 2024
@stefanprodan stefanprodan mentioned this issue Jan 18, 2024
Merged
@stefanprodan stefanprodan mentioned this issue Jan 22, 2024
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/server-side-apply SSA related issues and pull requests bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ssa: Restore namespace not specified error handing fluxcd/pkg
1 participant
@stefanprodan