Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssa: Restore namespace not specified error handing #720

Merged
merged 1 commit into from
Jan 18, 2024
Merged

ssa: Restore namespace not specified error handing #720

merged 1 commit into from
Jan 18, 2024

Conversation

stefanprodan
Copy link
Member

Fix regressing bug introduced in SSA refactoring.

Fix: #716

@stefanprodan stefanprodan added bug Something isn't working area/server-side-apply SSA related issues and pull requests labels Jan 18, 2024
@stefanprodan
ssa: Restore namespace not specified error handing
2635630 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
darkowlzz
darkowlzz approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanprodan stefanprodan merged commit c2c9efe into main Jan 18, 2024
13 checks passed
@stefanprodan stefanprodan deleted the fix-ssa-ns-error branch January 18, 2024 14:56
@stefanprodan stefanprodan mentioned this pull request Feb 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makkes makkes makkes approved these changes

@darkowlzz darkowlzz darkowlzz approved these changes

Assignees
No one assigned
Labels
area/server-side-apply SSA related issues and pull requests bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect namespaced objects without a namespace specified
3 participants
@stefanprodan @makkes @darkowlzz