Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failfast option to ssa.Wait #609

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Jul 17, 2023

This pull request adds a FailFast option to the WaitOptions in the ssa pkg. When this option is set, the Wait function returns early if there are stalled resources.

Ref: fluxcd/flux2#3980
Ref: fluxcd/kustomize-controller#701

ssa/manager_wait.go Outdated Show resolved Hide resolved
@somtochiama somtochiama marked this pull request as ready for review July 20, 2023 09:57
@stefanprodan stefanprodan added enhancement New feature or request area/server-side-apply SSA related issues and pull requests labels Jul 31, 2023
ssa/manager_wait.go Outdated Show resolved Hide resolved
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama 🏅

@stefanprodan stefanprodan merged commit 4104c21 into fluxcd:main Jul 31, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/server-side-apply SSA related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants