Add proxy support for oci/auth login #808
Conversation
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
matheuscscp
force-pushed
the
oci-auth-proxy
branch
from
12b347d
to
8b5c43a
Compare
| if c.proxyURL != nil { | ||
| transport := http.DefaultTransport.(*http.Transport).Clone() | ||
| transport.Proxy = http.ProxyURL(c.proxyURL) | ||
| confOpts = append(confOpts, config.WithHTTPClient(&http.Client{Transport: transport})) |
There was a problem hiding this comment.
This made me wonder if the explicitly set proxy should be respected when the aws.Config is configured externally. It looks like we can modify the given aws.Config to add proxy to it. But the same can't be done in case of Azure. It'll work for GCP easily as there's no external client in that case.
I believe the ability to provide external config was added just to make testing easier. I don't think anyone uses it for anything else.
I think for consistency across all the clients, it's better to not try to add proxy if an external client config is provided. So, it's good as it is.
There was a problem hiding this comment.
LGTM
Thanks @matheuscscp 🏅
PS. I will do an oci release so we can move forward with image reflector.
Part of fluxcd/image-reflector-controller#612