Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable -race for go test #615

Merged
merged 6 commits into from
Jun 14, 2022
Merged

build: enable -race for go test #615

merged 6 commits into from
Jun 14, 2022

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Mar 15, 2022

No description provided.

@hiddeco hiddeco added the area/ci CI related issues and pull requests label Mar 15, 2022
@darkowlzz darkowlzz force-pushed the go-test-race branch 6 times, most recently from 7ec1ac5 to faeb4ed Compare March 16, 2022 22:51
@pjbgf pjbgf added this to the GA milestone Mar 30, 2022
@pjbgf pjbgf force-pushed the go-test-race branch 3 times, most recently from f58f794 to a828e91 Compare June 13, 2022 12:50
@pjbgf
Copy link
Member

pjbgf commented Jun 13, 2022

Not being able to reproduce the building issues on arm64, on Mac nor Linux. This may just be the runner misbehaving.

hiddeco and others added 5 commits June 14, 2022 09:25
Signed-off-by: Hidde Beydals <hello@hidde.co>
The variable used to store the information about proxied request was
being written to in the proxy server request handler and read for
assertion at the end of the test.
Replace the boolean variable with an atomic counter to count the number
of requests proxied, preventing the race condition.

Signed-off-by: Sunny <darkowlzz@protonmail.com>
Since the transport reuse is dependent on the garbage collection, the
result is inconsistent. It fails frequently when running the tests with
the go race detector. Remove the test.

Signed-off-by: Sunny <darkowlzz@protonmail.com>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Co-authored-by: Sunny <darkowlzz@protonmail.com>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@pjbgf
Copy link
Member

pjbgf commented Jun 14, 2022

The latest commit disables race detection on arm64 only, as our runners seem not to like it very much.
However, all other platforms would still keep it enabled.

Race detection is not working properly in our arm64 runners.
It has been tested against both M1 and linux arm64 machines
and in both cases the results were aligned with the other
platforms.

By disabling this we can ensure race detection is being
enforced on the other platforms, and we can later review
this position.

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@pjbgf pjbgf merged commit 0a993a8 into main Jun 14, 2022
@pjbgf pjbgf deleted the go-test-race branch June 14, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants