Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change GPS ground speed on MCDU Data GPS Monitor page from meters/second to knots #5848

Merged
merged 3 commits into from
Sep 20, 2021
Merged

fix: Change GPS ground speed on MCDU Data GPS Monitor page from meters/second to knots #5848

merged 3 commits into from
Sep 20, 2021

Conversation

donstim
Copy link
Contributor

@donstim donstim commented Sep 19, 2021

Fixes #5827

Summary of Changes

Changes the GPS Ground Speed readouts on the MCDU'S Data - GPS Monitor page from meters/second to knots

Screenshots (if necessary)

Screenshot (1194)

References

Additional context

Discord username (if different from GitHub): donbikes#4084

Testing instructions

Confirm that the GPS ground speeds shown on the MCDU --- Data -- GPS Monitor page agree with the ground speed shown on the navigation display.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

Change GPS ground speed from meters per second to knots
@donstim donstim marked this pull request as draft September 19, 2021 06:02
@donstim donstim changed the title fix: Change gps ground speed on mcdu data gps monitor page from meters/second to knots fix: Change GPS ground speed on MCDU Data GPS Monitor page from meters/second to knots Sep 19, 2021
@donstim donstim marked this pull request as ready for review September 19, 2021 06:31
@derl30n derl30n added this to the v0.8.0 milestone Sep 19, 2021
@TheSquirtingPantin
Copy link

Quality Assurance Tester

Discord: Remi#8871
Object of testing: #5848
Tier of Testing: 1
Date: 1/09/2021

Testing Process:

  1. Normal flight preparation
  2. Flight from LFBO to LFBO
  3. Visually verified GS on ND matching GPS data on DATA -> GPS page

Negatives: None

Conclusions: PASS. PR is working as expected.

@beheh beheh merged commit 2c9221e into flybywiresim:master Sep 20, 2021
aguther pushed a commit that referenced this pull request Oct 18, 2021
…s/second to knots (#5848)

* Update CHANGELOG.md

* Update A320_Neo_CDU_GPSMonitor.js

Change GPS ground speed from meters per second to knots

Co-authored-by: Benjamin Dupont <benjozorkfr@gmail.com>
aguther pushed a commit that referenced this pull request Oct 26, 2021
…s/second to knots (#5848)

* Update CHANGELOG.md

* Update A320_Neo_CDU_GPSMonitor.js

Change GPS ground speed from meters per second to knots

Co-authored-by: Benjamin Dupont <benjozorkfr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MCDU's GPS Monitor Ground Speed (GS) is incorrect
6 participants