Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Flight model update - reduce flap induced drag #7639

Merged
merged 16 commits into from
Dec 20, 2022
Merged

feat: Flight model update - reduce flap induced drag #7639

merged 16 commits into from
Dec 20, 2022

Conversation

donstim
Copy link
Contributor

@donstim donstim commented Dec 6, 2022

Fixes the following issue:
A commenter in the Discord chat channel noted that the A32NX was unable to climb after takeoff at MTOW if an engine becomes inoperative at V1. (https://discord.com/channels/738864299392630914/740722295009706034/1047406331662962718) Shomas and I tested it and concluded the commenter was correct; there is inadequate climb performance for engine-out heavy weight takeoffs.

Summary of Changes

This fix reduces the induced drag for flaps down configurations. At heavy weights, the airplane is operating at higher lift coefficients. The drag level was too high (L/D too low) to provide adequate climb or acceleration capability.

Idle thrust was increased so that the decel condition used for testing in CONF 3 continues to be met with the lower induced drag.

The flap drag polars used for VNAV guidance calculations were adjusted to match the new flap drag levels.

Reducing the flap induced drag required re-tuning total flap drag for each flap configuration.

Screenshots (if necessary)

References

Screenshot (2562)

Additional context

Be aware that, due to the hydraulics simulation, there may be one or multiple elevator pitch down pulses upon gear retraction with one engine inoperative. This issue is beyond the scope of this PR.

Discord username (if different from GitHub): donbikes#4084

Testing instructions

This PR enables climb and acceleration capability after engine failure at V1 for heavy weight takeoffs (as long as the takeoff weight is within the takeoff climb limited takeoff weight for the airplane). For testing purposes, the airplane is within the climb limited takeoff weight for any takeoff flap configuration at sea level, ISA temperature, zero wind. Be aware that to minimize drag, you should not delay gear retraction and will need to apply rudder to minimize sideslip drag. Also, be aware of the issue discussed under "Additional context." Also see the engine failure takeoff procedure in "References."

CONF 3 will be more critical than CONF 2, which will be more critical than CONF 1+F due to the L/D relationships at V2 speed.
MTOW at sea level, ISA, zero wind is below the climb-limited weight, that is, you should not be limited by climb performance for these conditions. For the more adventurous, an example of a climb-limited takeoff condition would be at SBGO rwy 14, 40C, 78.5T, CONF 3, V1/VR/V2 of 135/139/140. For this condition, an average climb rate of 350-400 fpm should be achievable.

To simulate an engine failure, I bind a keystroke to "Toggle Engine 1 Fuel Valve" (and/or engine 2 fuel valve) under the "Instruments and Systems" "Fuel" control bindings.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@github-actions github-actions bot added this to 🟡 Code Review: Ready for Review in Quality Assurance Dec 6, 2022
@donstim donstim marked this pull request as draft December 6, 2022 06:14
@donstim donstim marked this pull request as ready for review December 7, 2022 05:49
Quality Assurance automation moved this from 🟡 Code Review: Ready for Review to 🟣 QA Team Review: Ready to Test Dec 8, 2022
@Saschl Saschl added the Exp Available on experimental branch (for testing) label Dec 11, 2022
@2hwk 2hwk added this to the v0.10.0 milestone Dec 12, 2022
@mico975
Copy link
Contributor

mico975 commented Dec 18, 2022

Quality Assurance Tester Report

Discord : mico#3145
Object of testing: #7639
Tier of Testing : 1
Date : 18/12/2022

Testing Process:
CONF 3 will be more critical than CONF 2, which will be more critical than CONF 1+F due to the L/D relationships at V2 speed.
MTOW at sea level, ISA, zero wind is below the climb-limited weight, that is, you should not be limited by climb performance for these conditions. - OK
For the more adventurous, an example of a climb-limited takeoff condition would be at SBGO rwy 14, 40C, 78.5T, CONF 3, V1/VR/V2 of 135/139/140. For this condition, an average climb rate of 350-400 fpm should be achievable. - OK, as described

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM, did a bunch of engine failured at/around V1.

@2hwk 2hwk merged commit ac688c2 into flybywiresim:master Dec 20, 2022
Quality Assurance automation moved this from 🟣 QA Team Review: Ready to Test to ✔️ Done Dec 20, 2022
Eearslya pushed a commit to Eearslya/a32nx that referenced this pull request Jan 4, 2023
* Update CHANGELOG.md

Reduces drag for engine-out heavy weight takeoffs

* Delete flight_model.cfg

* Delete engines.cfg

* Add files via upload

* Update engines.cfg

* Update FlightModel.ts

* Update flight_model.cfg

* Update EngineModel.ts

* Update src/fmgc/src/guidance/vnav/EngineModel.ts
@donstim donstim deleted the feat-Flight-model-update-flap-induced-drag branch January 19, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Exp Available on experimental branch (for testing)
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants