Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: small changes after msfs sdk update #7962

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

Saschl
Copy link
Contributor

@Saschl Saschl commented Apr 12, 2023

Summary of Changes

  1. Remove custom simvar override for msfs sdk instruments
  2. Use GenericDataListener as a more performant way to sync

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  1. Check if PFD works normally (no extensive tests needed, just check it turns on and updates)
  2. Load a route and verify that all vectors are properly transferred to the ND (== green line shows on ND as expected)

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

1. Remove custom simvar override for msfs sdk instruments
1. Use GenericDataListener as a more performant way to sync
@frenchairbuspilot
Copy link

Discord : jp320#3336
Object of testing: #7962
Tier of Testing : 1
Date : 12/04/2023

Testing Process:
Loaded simbrief for a quick EBBR ELLX, loading went great on nd and mcdu.
all phases of flight as expected on FMA, even with constraints on altitude during arrival.

Negatives:
Only remark is I did not have a TOD arrow nor line in mcdu, i don't know if it's linked to the arrival of what ( LNO3D DICK3C trans in ELLX)

Testing Results:
Passed

@2hwk 2hwk added this to the v0.10.0 milestone Apr 13, 2023
Copy link
Member

@tracernz tracernz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd personally think it's not worth fixing up the old sync and instead just switch over to EventBus, but since it's done SGTM.

@Saschl
Copy link
Contributor Author

Saschl commented Apr 13, 2023

I'd personally think it's not worth fixing up the old sync and instead just switch over to EventBus, but since it's done SGTM.

Agreed, but it went faster than expected :D

@Saschl Saschl merged commit 8ce167d into flybywiresim:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants