Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nd): font size and ts errors #8063

Merged
merged 19 commits into from
Jul 7, 2023
Merged

Conversation

Saschl
Copy link
Member

@Saschl Saschl commented Jun 5, 2023

Fixes #8087

Summary of Changes

While finishing the NDv2, the font size of the approach message was changed to be more accurate. But other elements in the upper region on the ND were untouched. This adapts the font sizes of the remaining elements to match the approach message.

Additionally, overlapping Range/Mode changes should be fixed not appear when MAP NOT AVAIL flag is being shown

There was also an error introduced in the PFD which is fixed now.

Screenshots (if necessary)

image

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  1. Before aligning, switch ND modes and range and make sure they do not appear.
  2. After aligning, do the same and ensure they do not overlap (range change message should override mode change message)
  3. Make sure everything in the upper region of the ND is available and readable (GS/TAS/TO WPT Indication (distance/ETA...)
  4. Turn off the FDs, ensure you are in selected heading and verify the heading indicator on the PFD shows up (given the selected heading is in range)

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@Saschl Saschl marked this pull request as ready for review June 7, 2023 15:13
@github-actions github-actions bot added this to 🟡 Code Review: Ready for Review in Quality Assurance Jun 7, 2023
Quality Assurance automation moved this from 🟡 Code Review: Ready for Review to 🟣 QA Team Review: Ready to Test Jun 16, 2023
@tracernz
Copy link
Member

Something to check for font sizes is compare PFD/ND from a square-on photo showing both to make sure there's a bit of consistency..

@alepouna
Copy link
Member

QA Report

Discord: alepouna
Object of testing: #8063
Tier of Testing : 1
Date : 25/6/2023

Testing Process:

  • Start flight
  • Check top ND, TO WPT, distance and ETA and runway indication, wind

Negatives:
GS/TAS numbers are next to the labels without any margin, is this normal? If this is normal, consider this PASSED. If its not normal consider this NOT PASSED.
image

Testing Results:
Unsure - Refer to negatives

@alepouna
Copy link
Member

QA Report

Discord: alepouna
Object of testing: #8063
Tier of Testing : 1
Date : 26/6/2023

Testing Process:

  • Start flight
  • Check top ND, TO WPT, distance and ETA and runway indication, wind
  • Check all ND pages

Testing Results:
Passed

@2hwk 2hwk added this to the v0.10.0 milestone Jun 29, 2023
@Saschl Saschl modified the milestones: v0.10.0, v0.11.0 Jun 30, 2023
@Saschl Saschl merged commit 6faebce into flybywiresim:master Jul 7, 2023
6 checks passed
Quality Assurance automation moved this from 🟣 QA Team Review: Ready to Test to ✔️ Done Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[ND] Range Change and Mode Change messages overlapping with MAP NOT AVAIL
6 participants