fix: remove upload of fragments to github #8400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installer uses cf and we upload the full package to github as an alternative for installing
Benjozork
approved these changes
Jan 10, 2024
Quality Assurance
automation
moved this from 🟡 Code Review: Ready for Review
to 🟣 QA Team Review: Ready to Test
Jan 10, 2024
Benjozork
changed the title
Benjozork
changed the title
|
Merging, in case we still want GitHub as fallback, we can restore the changes and make the necessary adaptions. |
Quality Assurance
automation
moved this from 🟣 QA Team Review: Ready to Test
to ✔️ Done
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installer uses cf and we upload the full package to github as an alternative for the installer.
Summary of Changes
Removing the upload of fragments to github as I could not find/remember any usage currently
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.