Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pfd): (fix after revert): Add vertical deviation indicator, ROW/ROP/OANS warnings v2 #8682

Merged
merged 47 commits into from
Jul 2, 2024

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Jun 16, 2024

Summary of Changes

Version 1 of this PR introduced a regression in the A32NX (leading to AP and V speeds issues), which should be fixed by this PR.
Relevant for both A380X and A32NX.

  • Adds OANS, ROP and ROW warnings to the PFD and aural alerts
  • Transmits new EGPWS discrete words from the GPWS module
  • Implements stall warning (aural alert and PFD warning)

A380X only:

  • Adds GPWS alerts to PFD
  • Ports the VDEV indicator, as well as the upper and lower speed limits from the a32nx to the a380x
  • Adds LS reminder for ILS, subsequently move marker (OM/MM/IM) information
  • ILS information: Frequency now has the same font size before and after decimal point, see references

Screenshots (if necessary)

image
image
image
image
image
image
image
image
image
image

A380X only:
image
image
image
image
image
image
image
image

References

https://www.youtube.com/watch?v=EorNGwNTzwQ
https://www.navblue.aero/product/rops-plus/
https://safetyfirst.airbus.com/app/themes/mh_newsdesk/documents/archives/the-runway-overrun-prevention-system.pdf
https://www.youtube.com/watch?v=FbCIjWaMqTI
https://www.youtube.com/watch?v=hDh_9MEz-hg
image

Additional context

Discord username (if different from GitHub): floridude

Testing instructions

Acceptance criteria: 1x Tier 1 test with all test cases passed, 2x Tier 2 tests passed
Testing of functional ROW/ROP on A32NX not yet possible.

For A32NX:
Test 1: Stall warning
Bring aircraft into alternate law (e.g. by turning both SECs to OFF), throttle to idle and maximum pitch up, until the aircraft enters a stall.
An aural warning "STALL, STALL", shall be heard.

Test 2: GPWS warnings
Please perform a flight triggering the following GPWS warnings, and confirm that there has been no regression, i.e. they still trigger:

  • Sinkrate
  • Pull Up
  • Terrain
  • Don't Sink
  • Too Low Gear
  • Too Low Flaps
  • Too Low Terrain
  • Glideslope

Test 3: ROP/ROW Warnings in A32NX
To trigger these manually, set the local variable A32NX_ROW_ROP_WORD_1 to the following value:
MAX BRAKING: 14046724096.000
MAX REVERSE: 14053015552.000
IF WET: RWY TOO SHORT: 14060355584.000
RWY TOO SHORT: 14068219904.000

Test 4:
Prepare FMS with departure runway + SID
After T/O, NAV should engage after SRS, FD and AP should follow programmed route

Test 5:
Spawn A32NX on runway, speed tape should not exhibit red markers indicating missing/erroneous data

For the A380X, the stall warning won't work because of the missing PseudoFWC.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

flogross89 and others added 30 commits April 29, 2024 00:36
A32NX: Add GPWS discrete word to GPWS,
Both: warnings position update
# Conflicts:
#	fbw-a380x/src/systems/instruments/src/PFD/FMA.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/LandingSystemIndicator.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/PFD.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/SpeedIndicator.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/instrument.tsx
@Saschl
Copy link
Member

Saschl commented Jun 30, 2024

QA Report

Discord: Saschl
Tier of Testing: 2

Testing Process:

Full flight LOWW-LOWI.

Test 1: Stall warning
Bring aircraft into alternate law (e.g. by turning both SECs to OFF), throttle to idle and maximum pitch up, until the aircraft enters a stall.
An aural warning "STALL, STALL", shall be heard.

Tested and confirmed.

Test 2: GPWS warnings
Please perform a flight triggering the following GPWS warnings, and confirm that there has been no regression, i.e. they still trigger:

Sinkrate
Pull Up: Pass
Terrain: Not working
Don't Sink:
Too Low Gear: (not working but to be fixed in another PR I believe: #8136)
Too Low Flaps (not working but to be fixed in another PR I believe: #8136)
Too Low Terrain: Pass
Glideslope: Pass (no aural alerts but that simply does not seem to be implemented yet)

In general: all the warnings that seem to implemented do trigger as they did before.

Test 3: ROP/ROW Warnings in A32NX
To trigger these manually, set the local variable A32NX_ROW_ROP_WORD_1 to the following value:
MAX BRAKING: 14046724096.000
MAX REVERSE: 14053015552.000
IF WET: RWY TOO SHORT: 14060355584.000
RWY TOO SHORT: 14068219904.000

All pass.

Test 4:
Prepare FMS with departure runway + SID
After T/O, NAV should engage after SRS, FD and AP should follow programmed route

Pass :)

Test 5:
Spawn A32NX on runway, speed tape should not exhibit red markers indicating missing/erroneous data

Pass :)

Testing Results:
Passed

Negatives:
Master Caution is active during power up. Maybe we can add a timeout to simulate FWC startup?

Media:

Microsoft.Flight.Simulator.2024-06-30.22-36-22.mp4

@flogross89
Copy link
Contributor Author

Thanks, @Saschl ! I only added a chime inhibition during startup, I will also inhibit the master warning/caution indicators

@flogross89
Copy link
Contributor Author

@Saschl I'm now inhibiting master warnings and cautions for five seconds after AC ESS has been powered on (where FWC 1 sits). Did you have this in mind?

Please advise, this feels like a new feature, don't know how this was handled before.

@lukecologne
Copy link
Member

lukecologne commented Jul 2, 2024

I'm now inhibiting master warnings and cautions for five seconds after AC ESS has been powered on (where FWC 1 sits). Did you have this in mind?

Please advise, this feels like a new feature, don't know how this was handled before.

You probably mean DC ESS? FWS are in the CPIOM Cs, which are powered by DC ESS and DC 2.
In general pretty much all avionics that I know of are powered by DC busses, not AC

@flogross89
Copy link
Contributor Author

I'm now inhibiting master warnings and cautions for five seconds after AC ESS has been powered on (where FWC 1 sits). Did you have this in mind?
Please advise, this feels like a new feature, don't know how this was handled before.

You probably mean DC ESS? FWS are in the CPIOM Cs, which are powered by DC ESS and DC 2. In general pretty much all avionics that I know of are powered by DC busses, not AC

I only have limited documentation about the a20n, but I thought it was AC ESS?
FWC also only seems to start up after connecting EXT PWR or the APU GEN. This page also says so: https://www.aviationhunt.com/airbus-a320-equipment-electrical-supply/

@lukecologne
Copy link
Member

lukecologne commented Jul 2, 2024

Oh, this is a A320 PR, sorry about that xD Just saw OANS and my mind went to A380..
In any case, IIRC the A320 FWCs might also DC, but I'll have to check that, one sec
Edit: FWCs are AC, disregard my comment

@Saschl Saschl added QA Passed and removed QA Failed labels Jul 2, 2024
@flogross89 flogross89 merged commit d13b44d into flybywiresim:master Jul 2, 2024
7 checks passed
Quality Assurance automation moved this from 🟣 QA Team Review: Ready to Test to ✔️ Done Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants