-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pfd): (fix after revert): Add vertical deviation indicator, ROW/ROP/OANS warnings v2 #8682
feat(pfd): (fix after revert): Add vertical deviation indicator, ROW/ROP/OANS warnings v2 #8682
Conversation
A32NX: Add GPWS discrete word to GPWS, Both: warnings position update
…ize before and after decimal point
…t gauge and PFD tapes
# Conflicts: # fbw-a380x/src/systems/instruments/src/PFD/FMA.tsx # fbw-a380x/src/systems/instruments/src/PFD/LandingSystemIndicator.tsx # fbw-a380x/src/systems/instruments/src/PFD/PFD.tsx # fbw-a380x/src/systems/instruments/src/PFD/SpeedIndicator.tsx # fbw-a380x/src/systems/instruments/src/PFD/instrument.tsx
# Conflicts: # .github/CHANGELOG.md # fbw-a380x/src/systems/systems-host/systems/LegacyGpws.ts # fbw-common/src/systems/shared/src/Arinc429RegisterSubject.ts
QA Report Discord: Saschl Testing Process: Full flight LOWW-LOWI. Test 1: Stall warning Tested and confirmed. Test 2: GPWS warnings Sinkrate In general: all the warnings that seem to implemented do trigger as they did before. Test 3: ROP/ROW Warnings in A32NX All pass. Test 4: Pass :) Test 5: Pass :) Testing Results: Negatives: Media: Microsoft.Flight.Simulator.2024-06-30.22-36-22.mp4 |
Thanks, @Saschl ! I only added a chime inhibition during startup, I will also inhibit the master warning/caution indicators |
# Conflicts: # .github/CHANGELOG.md
@Saschl I'm now inhibiting master warnings and cautions for five seconds after AC ESS has been powered on (where FWC 1 sits). Did you have this in mind? Please advise, this feels like a new feature, don't know how this was handled before. |
You probably mean DC ESS? FWS are in the CPIOM Cs, which are powered by DC ESS and DC 2. |
I only have limited documentation about the a20n, but I thought it was AC ESS? |
Oh, this is a A320 PR, sorry about that xD Just saw OANS and my mind went to A380.. |
Summary of Changes
Version 1 of this PR introduced a regression in the A32NX (leading to AP and V speeds issues), which should be fixed by this PR.
Relevant for both A380X and A32NX.
A380X only:
Screenshots (if necessary)
A380X only:
References
https://www.youtube.com/watch?v=EorNGwNTzwQ
https://www.navblue.aero/product/rops-plus/
https://safetyfirst.airbus.com/app/themes/mh_newsdesk/documents/archives/the-runway-overrun-prevention-system.pdf
https://www.youtube.com/watch?v=FbCIjWaMqTI
https://www.youtube.com/watch?v=hDh_9MEz-hg
Additional context
Discord username (if different from GitHub): floridude
Testing instructions
Acceptance criteria: 1x Tier 1 test with all test cases passed, 2x Tier 2 tests passed
Testing of functional ROW/ROP on A32NX not yet possible.
For A32NX:
Test 1: Stall warning
Bring aircraft into alternate law (e.g. by turning both SECs to OFF), throttle to idle and maximum pitch up, until the aircraft enters a stall.
An aural warning "STALL, STALL", shall be heard.
Test 2: GPWS warnings
Please perform a flight triggering the following GPWS warnings, and confirm that there has been no regression, i.e. they still trigger:
Test 3: ROP/ROW Warnings in A32NX
To trigger these manually, set the local variable A32NX_ROW_ROP_WORD_1 to the following value:
MAX BRAKING: 14046724096.000
MAX REVERSE: 14053015552.000
IF WET: RWY TOO SHORT: 14060355584.000
RWY TOO SHORT: 14068219904.000
Test 4:
Prepare FMS with departure runway + SID
After T/O, NAV should engage after SRS, FD and AP should follow programmed route
Test 5:
Spawn A32NX on runway, speed tape should not exhibit red markers indicating missing/erroneous data
For the A380X, the stall warning won't work because of the missing PseudoFWC.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.