-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(charts): plane symbol not visible #8684
Conversation
@@ -537,6 +537,8 @@ export const ChartViewer = () => { | |||
{aircraftIconVisible && boundingBox && ( | |||
<svg | |||
ref={planeRef} | |||
width={boundingBox.planview.pixels.x2 - boundingBox.planview.pixels.x1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure why we need the width and height now, but without it the svg always had a size of 0x0 pixels.
Non-QA Tester I tested this PR cause Saschl asked me to. Had the charts freeze on a regulary basis after commit 8676. Freeze is gone with this PR. Tested zooming, pushing all buttons ('fit to screen...' was the trigger of the freeze), draged the charts with the mouse. Everthing's working again. Oh, and the plane symbol is back and on the right place too, of course! Negatives: none Testing results: passed. |
QA Report Discord: alepouna Testing Process:
Testing Results: |
Fixes #[issue_no]
Summary of Changes
Fixes small regression that prevented the plane symbol on the charts from showing.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.