Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): plane symbol not visible #8684

Merged
merged 8 commits into from
Jun 25, 2024

Conversation

Saschl
Copy link
Member

@Saschl Saschl commented Jun 18, 2024

Fixes #[issue_no]

Summary of Changes

Fixes small regression that prevented the plane symbol on the charts from showing.

Screenshots (if necessary)

image

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  1. Open a chart in the EFB and make sure the yellow plane symbol is being shown and moves correctly. Also check that it is shown in the proper location (e.g. SIDS/STARS and Taxi charts)
  2. Use the "Fit chart to width" and "Fit chart to height" functionality and verify panning and zooming still works afterwards.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@github-actions github-actions bot added this to 🟡 Code Review: Ready for Review in Quality Assurance Jun 18, 2024
@@ -537,6 +537,8 @@ export const ChartViewer = () => {
{aircraftIconVisible && boundingBox && (
<svg
ref={planeRef}
width={boundingBox.planview.pixels.x2 - boundingBox.planview.pixels.x1}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure why we need the width and height now, but without it the svg always had a size of 0x0 pixels.

Quality Assurance automation moved this from 🟡 Code Review: Ready for Review to 🟣 QA Team Review: Ready to Test Jun 18, 2024
@Watsi01
Copy link
Contributor

Watsi01 commented Jun 25, 2024

Non-QA Tester

I tested this PR cause Saschl asked me to.

Had the charts freeze on a regulary basis after commit 8676.

Freeze is gone with this PR.

Tested zooming, pushing all buttons ('fit to screen...' was the trigger of the freeze), draged the charts with the mouse.
Loaded other charts, pinned them, loaded pinned charts. Deleted them and loaded new ones.

Everthing's working again.

Oh, and the plane symbol is back and on the right place too, of course!

Negatives: none

Testing results: passed.

@alepouna
Copy link
Member

QA Report

Discord: alepouna
Object of testing: #8684
Tier of Testing: 1
Date: 25/6/2024

Testing Process:

  • Use Navigraph charts in various display configurations & various charts

Testing Results:
Passed

@Benjozork Benjozork merged commit 1e8c85a into flybywiresim:master Jun 25, 2024
15 checks passed
Quality Assurance automation moved this from 🟣 QA Team Review: Ready to Test to ✔️ Done Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants