Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(press): excess residual pressure warning with adirs off #8690

Merged

Conversation

mjuhe
Copy link
Contributor

@mjuhe mjuhe commented Jun 20, 2024

Fixes #8642

Summary of Changes

After the introduction of PR #8511 and #8648, there was a condition where after landing, when switching off the ADIRS, the CPC was still sending an "excess residual pressure" signal to the FWC. This PR disables all signals when the ADIRS data is not valid.

I've also added a couple of accuracy changes to the excess residual pressure warning: 12 seconds delay (7 seconds to validate engines are off, and 5 to validate excess residual pressure) and trigger point at 0.036 PSI (from the FCOM).

The signal has been taken out of the discrete ARINC word and moved out of the CPC, as it's sent by an independent pressure switch.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub): Commander Ga

Testing instructions

To check the warning does not appear when it shouldn't: Do a short flight landing at an airport at sea level in a day with high atmospheric pressure (you can try something like 1040hpa). Turn on APU and APU bleed, switch off engines and switch off the ADIRS.

Verify no "EXCESS CAB PR" warning appears in the ECAM. When switching off the ADIRS, the delta pressure indication turns to "XX".

To check the warning does appear when it should, with a delay: Do a short flight, after landing swtich on the APU and APU bleed. Change the MODE SEL of the pressurization system to manual, and close the outflow valve (about 50% should be more than enough). Switch off the engines. Ensure the "EXCESS CAB PR" appears after 12 seconds.

Note: to speed up testing, instead of doing a flight, you can manually change the FWC flight phase to 10 in Model Behaviors after switching off the engines.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@github-actions github-actions bot added this to 🟡 Code Review: Ready for Review in Quality Assurance Jun 20, 2024
@mjuhe mjuhe marked this pull request as draft June 21, 2024 12:42
@mjuhe mjuhe marked this pull request as ready for review June 21, 2024 22:07
Quality Assurance automation moved this from 🟡 Code Review: Ready for Review to 🟣 QA Team Review: Ready to Test Jun 22, 2024
@Saschl Saschl moved this from 🟣 QA Team Review: Ready to Test to 🔴 Code Review: In progress in Quality Assurance Jun 26, 2024
@Saschl Saschl moved this from 🔴 Code Review: In progress to 🟣 QA Team Review: Ready to Test in Quality Assurance Jun 26, 2024
@tracernz
Copy link
Member

tracernz commented Jun 28, 2024

Development Team QA Report

Discord: tracernz
Object of testing: #8690
Tier of Testing: 1
Date: 28/6/2024

Testing Process:

  • Spawned at NZNV in the A32NX with QNH 1042 hPa.
  • Planned a short flight around the local area and returning to land at NZNV.
  • Carried out the flight and landed, started the APU and turned on APU bleed, turned off all 3 ADIRUs.
  • Waited 2 minutes (and checked for flight phase 10).
  • No EXCESS CAB PR warning seen.
  • Repeated the same flight, but after landing, started the APU, turned on APU bleed, kept the ADIRUs on.
  • Set the cabin press mode to MAN, closed the outflow valve a little past halfway, and shut down the engines.
  • Got EXCESS CAB PR level 3 warning from the FWC after a delay.

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM

@Maximilian-Reuter Maximilian-Reuter merged commit 49209eb into flybywiresim:master Jun 28, 2024
7 checks passed
Quality Assurance automation moved this from 🟣 QA Team Review: Ready to Test to ✔️ Done Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Unexpected ECAM WARNING "CAB PR EXCES RESIDUAL WARNING" occured after parking the aircraft
4 participants