-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API to get domain #5443
base: master
Are you sure you want to change the base?
Add API to get domain #5443
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5443 +/- ##
=======================================
Coverage 60.97% 60.98%
=======================================
Files 793 794 +1
Lines 51350 51370 +20
=======================================
+ Hits 31312 31326 +14
- Misses 17152 17157 +5
- Partials 2886 2887 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
32e8fd7
to
b268533
Compare
d022eb4
to
a15d27c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, some minor comments
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Why are the changes needed?
flytectl get execution
.What changes were proposed in this pull request?
How was this patch tested?
Tested by running flyteadmin with dev cluster and called the
GetDomains
function inAdminFetcherExtClient
by flytectl.Added unit test to:
Setup process
Screenshots
Check all the applicable boxes
Related PRs
In order to support domain selection in interactive CLI
Docs link