Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include group in apiVersion in plugin_collector #5457

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

trevormcguire
Copy link
Contributor

@trevormcguire trevormcguire commented Jun 7, 2024

Tracking issue

Closes #5429

Why are the changes needed?

Correctly sets apiVersion to include group; fixes the failed to list objects for ... warning in collect

What changes were proposed in this pull request?

ResourceLevelMonitor includes schema.GroupVersionKind (gvk). The changes here correctly set the apiVersion in collect by utilizing gvk.GroupVersion().String(), which puts "group" and "version" into a single "group/version" string

https://github.com/kubernetes/apimachinery/blob/703232ea6da48aed7ac22260dabc6eac01aab896/pkg/runtime/schema/group_version.go#L178-L182

How was this patch tested?

Built flytepropeller image with this change, deployed, ensured resources were correctly listed and ensured the aforementioned warning didn't appear.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Trevor McGuire <trevormcguire13@gmail.com>
Copy link

welcome bot commented Jun 7, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@trevormcguire trevormcguire changed the title Correctly set apiVersion in plugin_collector Include group in apiVersion in plugin_collector Jun 7, 2024
@pingsutw pingsutw requested a review from hamersaw June 7, 2024 20:58
@pingsutw pingsutw added the bug Something isn't working label Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.60%. Comparing base (25c3596) to head (a1ad308).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5457      +/-   ##
==========================================
- Coverage   61.07%   60.60%   -0.48%     
==========================================
  Files         793      775      -18     
  Lines       51226    49904    -1322     
==========================================
- Hits        31288    30242    -1046     
+ Misses      17062    16854     -208     
+ Partials     2876     2808      -68     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.90% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.97% <ø> (ø)
unittests-flyteidl ?
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <100.00%> (ø)
unittests-flytestdlib 65.80% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kumare3
Copy link
Contributor

kumare3 commented Jun 9, 2024

Cc @andrewwdye

@hamersaw
Copy link
Contributor

@trevormcguire thanks for the PR!

@hamersaw hamersaw merged commit de415af into flyteorg:master Jun 17, 2024
49 of 50 checks passed
Copy link

welcome bot commented Jun 17, 2024

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Plugin Collector does not include group
4 participants