Include group in apiVersion in plugin_collector #5457
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #5429
Why are the changes needed?
Correctly sets apiVersion to include group; fixes the
failed to list objects for ...
warning incollect
What changes were proposed in this pull request?
ResourceLevelMonitor
includesschema.GroupVersionKind
(gvk). The changes here correctly set theapiVersion
incollect
by utilizinggvk.GroupVersion().String()
, which puts "group" and "version" into a single "group/version" stringhttps://github.com/kubernetes/apimachinery/blob/703232ea6da48aed7ac22260dabc6eac01aab896/pkg/runtime/schema/group_version.go#L178-L182
How was this patch tested?
Built flytepropeller image with this change, deployed, ensured resources were correctly listed and ensured the aforementioned warning didn't appear.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link