-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-252 Fix broken mermaid diagrams in docs #5467
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5467 +/- ##
==========================================
- Coverage 61.93% 60.98% -0.96%
==========================================
Files 611 793 +182
Lines 36463 51313 +14850
==========================================
+ Hits 22582 31291 +8709
- Misses 11907 17136 +5229
- Partials 1974 2886 +912
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@davidmirror-ops looks like docs tests are failing because the MMCloud plugin example page has a 404ing link. Here's a PR to remove and redirect the MMCloud plugin pages -- once it's merged, I can update the branch in this PR and the tests should pass. |
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
@cosmicBboy I'm able to generate mermaid diagrams locally with the changes in this PR, but docs tests are failing with That is the location |
Why are the changes needed?
Closes #4864
What changes were proposed in this pull request?
npm install -g @mermaid-js/mermaid-cli
during build processCheck all the applicable boxes
Related PRs
#5373
Docs link
TK