reimplement functions in go-mouff-update, use ghreposervice #5470
+175
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: novahow <b08902047@ntu.edu.tw>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5470 +/- ##
==========================================
- Coverage 60.98% 60.88% -0.10%
==========================================
Files 793 794 +1
Lines 51313 51393 +80
==========================================
- Hits 31294 31292 -2
- Misses 17134 17215 +81
- Partials 2885 2886 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks for your PR. Can you fix the lint errors? |
eapolinario
reviewed
Jun 12, 2024
Comment on lines
+18
to
+20
| // type GitHubProvider struct { | ||
| // provider.Github | ||
| // } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
closes #5372
Why are the changes needed?
flytectl upgrade is not working after monorepo integration
What changes were proposed in this pull request?
Cloned the code from the original external package https://github.com/mouuff/go-rocket-update/blob/v1.5.4/pkg/provider/provider_github.go , and made modifications to fit our needs
How was this patch tested?
make test_unit
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link