Extend FMT_FALLTHROUGH compatibily to gcc and clang pre-C++17 #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Dec 10, 2019
include/fmt/format.h
Outdated
| #if __cplusplus == 201103L || __cplusplus == 201402L | ||
| # if defined(__clang__) | ||
| # define FMT_FALLTHROUGH [[clang::fallthrough]]; | ||
| # elif defined(__GNUC__) && __GNUC__ >= 7 |
There was a problem hiding this comment.
This can be simplified as FMT_GCC_VERSION >= 700.
|
Thanks for the PR! |
sthagen
added a commit
to sthagen/fmtlib-fmt
that referenced
this pull request
Dec 11, 2019
Extend FMT_FALLTHROUGH compatibily to gcc and clang pre-C++17 (fmtlib#1469)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.