Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STCOM-1180 Add match options to AdvancedSearch #2091

Merged
merged 7 commits into from
Jul 13, 2023
Merged

STCOM-1180 Add match options to AdvancedSearch #2091

merged 7 commits into from
Jul 13, 2023

Conversation

BogdanDenis
Copy link
Contributor

@BogdanDenis BogdanDenis commented Jul 5, 2023 •
edited
Loading

Description

Added new option match to Advanced Search. This will allow users to pick one of several matching options.

Screenshots

chrome_cmEqkIPC6b.mp4

Issues

STCOM-1180

Related PRs

folio-org/ui-inventory#2197
folio-org/stripes-smart-components#1376

This was referenced Jul 5, 2023
Merged
Merged
@github-actions
Copy link

github-actions bot commented Jul 5, 2023 •
edited
Loading

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 710d178. ± Comparison against base commit 142f02a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 5, 2023 •
edited
Loading

BigTest Unit Test Statistics

       1 files  ±0         1 suites  ±0   11s ⏱️ ±0s
1 380 tests ±0  1 374 ✔️ ±0  6 💤 ±0  0 ❌ ±0 
1 383 runs  ±0  1 377 ✔️ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit 710d178. ± Comparison against base commit 142f02a.

♻️ This comment has been updated with latest results.

@BogdanDenis BogdanDenis marked this pull request as ready for review July 10, 2023 08:08
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@BogdanDenis BogdanDenis merged commit 14d09d4 into master Jul 13, 2023
4 of 5 checks passed
@BogdanDenis BogdanDenis deleted the STCOM-1180 branch July 13, 2023 14:29
github-actions bot pushed a commit that referenced this pull request Jul 13, 2023
@BogdanDenis
STCOM-1180 Add match options to AdvancedSearch (#2091)
d3253b5 
* STCOM-1180 Add match options to AdvancedSearch

* STCOM-1180 Enable all tests

* STCOM-1180 Let AdvancedSearch consumers control query search options inclusion

* STCOM-1180 Rename AdvancedSearch prop to queryToRow

* STCOM-1180 Updated AdvancedSearch documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnC-80 JohnC-80 JohnC-80 approved these changes

@Dmytro-Melnyshyn Dmytro-Melnyshyn Dmytro-Melnyshyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BogdanDenis @JohnC-80 @Dmytro-Melnyshyn