STCOM-1319 Selection - consolidate/reduce onChange calls

[JohnC-80]

Since the implemenation for handling value props from outside of the component, we notice instances of onChange handlers happening multiple times as per STCOM-1319 where a query search will remain intact after resetAll is pressed once. This was due to a new render cycle happening even prior to the updated state of the component landing. In class-based react implementation, we had a callback for setState so that we could run logic in a space where we were assured that state had updated. It's possible for us to write a hook that could accomplish something like, but I decided to try and revisit the usage of downshift's state within the component, and if we could solely rely on that state, we could consolidate the onChange calls within its handler.

I destructured two new pieces from downshift's result, using their selectedItem and their update function selectItem - which I renamed to updateSelectedItem just to suit convention. I replaced our own state with this, and used the updateSelectedItem to update the selection when the value prop updates, so that all possible ways for the value to change will pass through downshift state handling/callback. Additionally, I checked the new selected item from state didn't match the provided value prop before calling onChange, limiting the onChange calls.

It's still important to track internal changes until the selected value comes back as the value prop, so the sentinel value awaitingChange is still necessary, but depending on downshift's state versus our own allows the chosenItem ref to be removed.

The useEffect for updating when dataOptions are updated was moved after the useCombobox hook so that it could observe the selectedItem from the hook.

[github-actions]

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 4e971b3. ± Comparison against base commit f9b8805.

♻️ This comment has been updated with latest results.

[github-actions]

BigTest Unit Test Statistics

       1 files  ±0         1 suites  ±0   13s ⏱️ ±0s
1 477 tests +1  1 469 ✔️ +1  8 💤 ±0  0 ❌ ±0 
1 479 runs  +1  1 471 ✔️ +1  8 💤 ±0  0 ❌ ±0 

Results for commit 4e971b3. ± Comparison against base commit f9b8805.

♻️ This comment has been updated with latest results.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud