Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STCOM-1322 Datepicker clear button not in tab order. #2336

Merged
merged 3 commits into from
Aug 19, 2024
Merged

STCOM-1322 Datepicker clear button not in tab order. #2336

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
feec7db
remove tabIndex -1 from Datepicker's clear button
JohnC-80 Aug 14, 2024
d0ad367
log changes
JohnC-80 Aug 14, 2024
62091b3
Merge branch 'master' into STCOM-1322
JohnC-80 Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
* Make `<MultiSelection>` less strict about item removal via `itemToKey` setting (`downshift`). Refs STCOM-1311.
* Conform `<Selection>`'s internal state when dataOptions prop changes after initial render. Refs STCOM-1313.
* Add the `showSortIndicator` property to MLC to display a sort indicator next to the sortable column names. Refs STCOM-1328.
* Remove `tabIndex="-1"` from `<Datepicker>`'s clear button, placing it in tab order. Refs STCOM-1322.

## [12.1.0](https://github.com/folio-org/stripes-components/tree/v12.1.0) (2024-03-12)
[Full Changelog](https://github.com/folio-org/stripes-components/compare/v12.0.0...v12.1.0)
Expand Down
1 change: 0 additions & 1 deletion lib/Datepicker/Datepicker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,6 @@ const Datepicker = (
onClick={internalClearDate}
aria-label={ariaLabel}
id={`datepicker-clear-button-${testId}`}
tabIndex="-1"
icon="times-circle-solid"
/>
)}
Expand Down
Loading