STCOM-1366 - Selection aggressive 'required' validation. #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l onBlur via nullish
JohnC-80
changed the title
|
zburke
approved these changes
Oct 9, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
* implement internal onBlur handler for Selection * add highlightedIndex to renderOptions dependencies. conditionally call onBlur via nullish * remove commented code * selection - include closeMenu function in stateReducer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STCOM-1366
React Final Form and redux form validate values using an onblur event. This can cause unwanted validation messages in the UI if the control is shifting focus to its open options list, when the user hasn’t yet had a chance to select a value yet.
Approach
Using refs for the options list containing element and the control itself, check to see if focus is still within the bounds of the component. If it isn't, trigger the provided
onBlurif any, and close the menu if necessary.Before: The control value is validated before any value has been selected, when the menu is opened.
After: Validation only occurs when the user
When the filter input is blurred naturally (tab key) the menu is closed and the
onBlurhandler is triggered.Additionally - I noticed issues with keyboard navigation of items in the list and updated dependencies on rendering functions accordingly.