When text is selected and either (, [ or { is pressed wrap selection in (), [], {} instead of replacing it. #757
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds key bindings to codemirror in order to handle the press of
(
,[
or{
more intuitively (citation needed).When user has done a text selection and presses
(
,[
or{
, the character replaces the text.With this PR, the behaviour changes to wrap the selection in brackets.
Note that the cursor is moved after the text
(selected-text)<HERE>
vs for example VSCode that goes to(selected-text<HERE>)
.Also remove the line that activates ''autoCloseBrackets" (because it doesn't!)