feat: remove concurrent transactions and messages handling #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiccardoM
changed the title
RiccardoM
added a commit
that referenced
this pull request
Nov 30, 2022
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> ## Description This PR prepares the code for release `v4.0.0` by: - updating `CHANGELOG.md` to contain the proper changes - updating the `go.mod` to use the proper go module (`github.com/forbole/juno/v4`) Depends-on: #84 Depends-on: #86 ## Checklist - [x] Targeted PR against correct branch. - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [x] Re-reviewed `Files changed` in the Github PR explorer.
MonikaCat
pushed a commit
that referenced
this pull request
Jan 19, 2024
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> ## Description This PR prepares the code for release `v4.0.0` by: - updating `CHANGELOG.md` to contain the proper changes - updating the `go.mod` to use the proper go module (`github.com/forbole/juno/v4`) Depends-on: #84 Depends-on: #86 ## Checklist - [x] Targeted PR against correct branch. - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [x] Re-reviewed `Files changed` in the Github PR explorer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the concurrent handling of transactions and messages. This is because it might cause some wrongful handling then a transaction contains messages that perform opposite operations.
As an example, consider a transaction that contains, in the given order:
MsgRevokeFeeAllowancefrom Alice to BobMsgGrantFeeAllowancefrom Alice to BobIf those messages are handled concurrently, since concurrency does not guarantee the order of handling, the following cases are both likely to happen:
MsgRevokeFeeAllowancegets handled beforeMsgGrantFeeAllowanceMsgGrantFeeAllowancegets handled beforeMsgRevokeFeeAllowanceIf the parser is storing the existing fee allowances, then the following results are equally likely to happen:
MsgRevokeFeeAllowancegets handled beforeMsgGrantFeeAllowance), orMsgGrantFeeAllowancegets handled beforeMsgRevokeFeeAllowance)Obviously, the second case is not the correct one and is only due to the concurrent handling of messages.
The same might happen on a transaction level, with two transactions containing similar messages.
To solve this, we need to remove the concurrent handling of transactions and messages.
Checklist
Files changedin the Github PR explorer.