Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add preprocessor to schema #4

Merged
merged 5 commits into from
Oct 16, 2022
Merged

feat: add preprocessor to schema #4

merged 5 commits into from
Oct 16, 2022

Conversation

gnikit
Copy link
Member

@gnikit gnikit commented Oct 11, 2022

No description provided.

@gnikit gnikit requested a review from awvwgk October 11, 2022 18:12
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #4 (cd5ce9d) into main (5792c95) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          134       143    +9     
=========================================
+ Hits           134       143    +9     
Impacted Files Coverage Δ
src/fpm/metadata/models.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gnikit
Copy link
Member Author

gnikit commented Oct 11, 2022

So this is not ideal, since we do not capture the cases of

[preprocessor.cpp]
...

or

[preprocessor]
preprocessor.cpp = ...

src/fpm/metadata/models.py Outdated Show resolved Hide resolved
src/fpm/metadata/models.py Outdated Show resolved Hide resolved
@awvwgk awvwgk merged commit b964659 into main Oct 16, 2022
@awvwgk awvwgk deleted the feat/preprocessor branch October 16, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants