Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: macros don't propage to C executables #779

Merged
merged 4 commits into from
Oct 19, 2022
Merged

bug: macros don't propage to C executables #779

merged 4 commits into from
Oct 19, 2022

Conversation

gnikit
Copy link
Member

@gnikit gnikit commented Oct 17, 2022

Fixes #777

@gnikit gnikit changed the title bug: macros don't propage to executables bug: macros don't propage to C executables Oct 17, 2022
Copy link
Contributor

@zoziha zoziha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing @gnikit , LGTM.

Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gnikit, code changes look good to me 👍 Few minor points about the example package:

  • Do we need the stub.c file for this example?
    • If not, can we move the header file into an include subdirectory and simplify the manifest?
  • Are you able to update example_packages/README.md with the new example packages and why they're needed?

@gnikit
Copy link
Member Author

gnikit commented Oct 19, 2022

Thanks @gnikit, code changes look good to me +1 Few minor points about the example package:

  • Do we need the stub.c file for this example?

    • If not, can we move the header file into an include subdirectory and simplify the manifest?

I will have a look at this today. BTW we might have a bug in our hands. Unfortunately, I don't have a OS X machine handy anymore so I can't really dig around.

Sure thing.

@gnikit
Copy link
Member Author

gnikit commented Oct 19, 2022

@LKedward test restructured and example_packages/README.md updated. I sorted the example names and added descriptions for a couple more projects that were missing from the table. Descriptions added (c_main, c_main_preprocess, hello_fpm_path and preprocess_cpp_c)

Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks! All looks good to me 👍

@gnikit gnikit merged commit 1c211f6 into main Oct 19, 2022
@gnikit gnikit deleted the gnikit/issue777 branch October 19, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: preprocess.cpp does not propage macros to compiler
3 participants