Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cpp preprocessor flag for dependencies #783

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

zoziha
Copy link
Contributor

@zoziha zoziha commented Oct 22, 2022

  • Use logical :: has_cpp to handle the cpp preprocessor settings for dependency occurrences, thus activating cpp flags;
  • Modify subroutine set_preprocessor_flags to set_cpp_preprocessor_flags
  • Add a example package: preprocess_cpp_deps;
  • Fix Dependency-only cpp preprocessor settings do not work #782.

Description

All dependencies are accessed in the do loop, so check whether there are any cpp preprocessor settings in the loop.

Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting together a fix so quickly @zoziha! Changes look good to me, but I'm not so familiar with this code so I will defer to @arteevraina for a full review

Copy link
Member

@arteevraina arteevraina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and works fine as well. 🚀
Thanks @zoziha

@zoziha
Copy link
Contributor Author

zoziha commented Oct 25, 2022

Thank you @LKedward @arteevraina for your patient review :)

@zoziha
Copy link
Contributor Author

zoziha commented Oct 26, 2022

With 2 approvals, I'll merge this PR: It fixes a bug of preprocess.cpp, it's good to be part of fpm-0.7.0.

@zoziha zoziha merged commit 1c60d12 into fortran-lang:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency-only cpp preprocessor settings do not work
3 participants