Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manifest): add C++ flags in profiles #786

Merged
merged 1 commit into from
Oct 31, 2022
Merged

feat(manifest): add C++ flags in profiles #786

merged 1 commit into from
Oct 31, 2022

Conversation

gnikit
Copy link
Member

@gnikit gnikit commented Oct 27, 2022

The original PR #653 was opened before C++ support was added.
This PR brings the profiles manifest parsing up to date.
This is effectively a maintenance PR.

The original PR #653 was opened before C++ support was added.
This PR brings the profiles manifest parsing up to date.
@gnikit gnikit requested a review from a team October 27, 2022 12:11
Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gnikit! LGTM 👍

Copy link
Contributor

@zoziha zoziha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing @gnikit .

@gnikit gnikit merged commit 440272a into main Oct 31, 2022
@gnikit gnikit deleted the feat/cpp-profiles branch October 31, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants