Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.sh: fix broken wget in install script #842

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

perazz
Copy link
Contributor

@perazz perazz commented Feb 20, 2023

install.sh: quote "$FETCH" to pass it as a single string, as passing $FETCH would split the command as different arguments. If so, wget would dump to a local file instead of stdout, which breaks the install script.

Also put one more check.

cf. #836

passing `$FETCH` would split the command as different arguments
@vmagnin
Copy link
Member

vmagnin commented Feb 20, 2023

Just a small detail, as there is already another exit 1, it would be a better practice to use exit 2 for that second error.

@awvwgk awvwgk merged commit a338c03 into fortran-lang:main Feb 22, 2023
@perazz perazz mentioned this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants