Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding metapackages with standard dependency syntax #928

Merged
merged 3 commits into from
Jun 10, 2023
Merged

Allow overriding metapackages with standard dependency syntax #928

merged 3 commits into from
Jun 10, 2023

Conversation

perazz
Copy link
Contributor

@perazz perazz commented Jun 8, 2023

Address #926. See fortran-lang/stdlib#715

New logic:

  1. Is a valid standard dependency syntax? -> use that
  2. Is a valid metapackage? -> use as metapackage
  3. None of the above? error
  • implementation
  • tests

@Carltoffel @minhqdao @arteevraina @henilp105

henilp105
henilp105 approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@henilp105 henilp105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @perazz , Looks good to me.

@perazz perazz mentioned this pull request Jun 10, 2023
Closed
@beddalumia beddalumia mentioned this pull request Jun 10, 2023
Merged
beddalumia added a commit to QcmPlab/HoneyTools that referenced this pull request Jun 10, 2023
@beddalumia
Merge pull request #6 from bellomia/master [FIX fpm build]
55fe163 
Note that fortran-lang/fpm#928 would have probably fixed this anyway, but since fpm 0.9.0 has been released, we prefer to move anyway to the new matapackage syntax, for stdlib.
@perazz
Copy link
Contributor Author

perazz commented Jun 10, 2023

Thank you @henilp105, will merge this as completed.

@perazz perazz merged commit 6d33e74 into fortran-lang:main Jun 10, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henilp105 henilp105 henilp105 approved these changes

@Carltoffel Carltoffel Awaiting requested review from Carltoffel

@arteevraina arteevraina Awaiting requested review from arteevraina

@minhqdao minhqdao Awaiting requested review from minhqdao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@perazz @henilp105