Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPI: add mpi and mpi_f08 to the list of external modules #930

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

perazz
Copy link
Contributor

@perazz perazz commented Jun 8, 2023

Address #929.

Not all MPI implementations offer valid mpi and mpi_f08 (most notably, MS-MPI + gfortran), so they're not in the CI.

  • add metapackage facility to introduce external modules
  • on MPI metapackage request, add mpi and mpi_f08 to the list of external modules, so fpm does not require them to be in any of the project source files.

@Carltoffel @minhqdao @arteevraina @henilp105

Copy link
Member

@arteevraina arteevraina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Member

@henilp105 henilp105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @perazz , looks good to me.

@perazz
Copy link
Contributor Author

perazz commented Jun 8, 2023

Thank you @arteevraina @henilp105, merging now.

@perazz perazz merged commit c9072d9 into fortran-lang:main Jun 8, 2023
15 checks passed
@perazz perazz mentioned this pull request Jun 8, 2023
Carltoffel

This comment was marked as duplicate.

Copy link
Member

@Carltoffel Carltoffel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Edit: Sorry for the duplicate. I tried to review without leaving a comment, but didn't succeed. How can I approve a PR without a comment? Or isn't it possible because it's already merged? 🤔

@perazz
Copy link
Contributor Author

perazz commented Jun 12, 2023

Thank you @Carltoffel, yep - sorry I had merged the PR already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants