Fixed Issue: #1020
Merged
Fixed Issue: #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yashLadha Is crashing stopped or not?? App is still crashing on my side. |
|
App has stopped crashing. Because it is looking for the tag of skills when a website has given as input. But i still have to figure out the layout which is inflating. It is currently inflating chatViewHolder with default content. @collinx |
* Crashing of app on input of a webpage Fixes fossasia#961
yashLadha
force-pushed
the
website_CRASH
branch
from
0488b38
to
3dc6102
Compare
|
@collinx @chiragw15 Please review it has stopped crashing. I have added necessary screen shot |
collinx
suggested changes
Oct 9, 2017
There was a problem hiding this comment.
@yashLadha Yup, the app is not crashing and showing appropriate results for website link search. Good Work 👍
Please do fix incorrect inflation.
|
@collinx I have implemented changes on the inflation as well. |
collinx
approved these changes
Oct 9, 2017
chiragw15
approved these changes
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #961