Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handling of Back Button in SkillsActivity #951

Merged
merged 2 commits into from
Sep 24, 2017
Merged

fix: Handling of Back Button in SkillsActivity #951

merged 2 commits into from
Sep 24, 2017

Conversation

collinx
Copy link
Member

@collinx collinx commented Sep 19, 2017

fixes #950

Changes:

  1. On pressing back button on SkillDetailsFragment, SkillListingFragment will be visible.
  2. The back button is synchronized with the back button of the action bar.

@collinx collinx force-pushed the newfix branch 6 times, most recently from 870bfc4 to 3736d6d Compare September 22, 2017 16:26
chiragw15
chiragw15 reviewed Sep 22, 2017
View reviewed changes
Copy link
Member

@chiragw15 chiragw15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On pressing back button from skill details fragment, the action bar title does not change. @collinx Please look into it. Thanks.

@collinx
Copy link
Member Author

collinx commented Sep 22, 2017

@chiragw15 thanks for the review. Changes were done, Please do check. 😄

@chiragw15 chiragw15 merged commit f6ad608 into fossasia:development Sep 24, 2017
@collinx collinx deleted the newfix branch September 25, 2017 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiragw15 chiragw15 chiragw15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better Handling of Back Button in SkillsActivity
2 participants
@collinx @chiragw15