Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the order of curly braces and updated the API URL #76

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

AnupKumarPanwar
Copy link
Member

Fixes issue : #75 (Error on starting the server)

Changes: Updated the API URL and fixed the order of closing curly braces.

Screenshots for the change:
NA

Copy link
Member

@akshatnitd akshatnitd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnupKumarPanwar It would be nice to see, if the code is also indented.

Copy link
Member

@hkedia321 hkedia321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnupKumarPanwar Please check the Codacy error. Also please squash the commits.

@AnupKumarPanwar
Copy link
Member Author

Codacy is checking builds as per the production standards For example, it says remove all console.log() statements. But I think this branch is for development purpose and it would be difficult to debug the code without such statements.

@ThatDNS
Copy link
Member

ThatDNS commented May 11, 2018

@AnupKumarPanwar You can comment out console.log() statements.

Copy link
Member

@Akshat-Jain Akshat-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the Codacy error and also squash all the commits. Thanks 😄

Copy link
Member

@akshatnitd akshatnitd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy errors. Remove/Comment the console.log() statements.

Copy link
Member

@PrP-11 PrP-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must use double quotes for strings according to codacy standards.

@AnupKumarPanwar
Copy link
Member Author

@akshatnitd These console log statements will log the errors on the console of the server and can be used if case the server crashes at some endpoint. Commenting them out will make debugging difficult. It will not log anything on the wen browser's console. I think they should stay.

@AnupKumarPanwar
Copy link
Member Author

@PrP-11 But Travis says that keep the strings in single quotes.

Copy link
Member

@ThatDNS ThatDNS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnupKumarPanwar Please resolve the merge conflict.

Copy link
Member

@samagragupta samagragupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants