-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the order of curly braces and updated the API URL #76
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnupKumarPanwar It would be nice to see, if the code is also indented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnupKumarPanwar Please check the Codacy error. Also please squash the commits.
Codacy is checking builds as per the production standards For example, it says remove all console.log() statements. But I think this branch is for development purpose and it would be difficult to debug the code without such statements. |
@AnupKumarPanwar You can comment out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the Codacy error and also squash all the commits. Thanks 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy errors. Remove/Comment the console.log()
statements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You must use double quotes for strings according to codacy standards.
@akshatnitd These console log statements will log the errors on the console of the server and can be used if case the server crashes at some endpoint. Commenting them out will make debugging difficult. It will not log anything on the wen browser's console. I think they should stay. |
@PrP-11 But Travis says that keep the strings in single quotes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnupKumarPanwar Please resolve the merge conflict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflicts.
Fixes issue : #75 (Error on starting the server)
Changes: Updated the API URL and fixed the order of closing curly braces.
Screenshots for the change:
NA