Fix description of direction for mui-slide #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description of the direction parameter for mui-slide states that this would be the side to slide from (`top`, `bottom` etc.). Did not work for me though ... after a short tour through the sources it turns out that it is actually the direction to *slide toward*, i.e., it takes the values `up`, `right`, `down` and `left`.
|
This needs to be edited in the source files for the component—our documentation is generated automatically from the Sass files. Edit it here and then run |
|
Ok, thanks for the pointers :). Now added the change in the source. |
gakimball
added a commit
that referenced
this pull request
Jan 18, 2016
Fix description of direction for mui-slide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description of the direction parameter for mui-slide states that this would be the side to slide from (
top,bottometc.). Did not work for me though ... after a short tour through the sources it turns out that it is actually the direction to slide toward, i.e., it takes the valuesup,right,downandleft.