Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: patch empty event args #3348

Merged
merged 1 commit into from
Sep 25, 2022
Merged

fix: patch empty event args #3348

merged 1 commit into from
Sep 25, 2022

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Sep 25, 2022

Motivation

Closes #3347

This is a known bug in ethabi, rust-ethereum/ethabi#206. the decoding impl is a bit cryptic...

Instead, this is fixed by temporarily patching empty event args:

forge test -vvvvv                                                                                                        
[⠆] Compiling...
No files changed, compilation skipped

Running 1 test for test/Counter.t.sol:LogTest
[PASS] test() (gas: 1497)
Traces:
  [1497] LogTest::test() 
    ├─ emit log2(: 1, : 2)
    └─ ← ()

Solution

@mattsse mattsse added the T-bug Type: bug label Sep 25, 2022
@mattsse
Copy link
Member Author

mattsse commented Sep 25, 2022

test failures unrelated

@mattsse mattsse merged commit 40f7995 into foundry-rs:master Sep 25, 2022
iFrostizz pushed a commit to iFrostizz/foundry that referenced this pull request Nov 9, 2022
@mattsse @iFrostizz
fix: patch empty event args (foundry-rs#3348)
50bf8db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

Assignees
No one assigned
Labels
T-bug Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The tracer does not print event logs correctly
2 participants
@mattsse @rkrasiuk