fix(ci): flexibly handle forge-std being installed with tag or untagged #9003
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
yash-atreya
as code owners
zerosnacks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Temporarily fixes flaky behavior of
tagbeing displayed for failing CI as seen here: https://github.com/foundry-rs/foundry/actions/runs/11139687639/job/30956872092 to unblock the CISnapbox trips over space before
[..]being included when installed with tag but not withoutRelated: #7225
Related: #8308
We are intending to pin to
forge-stdtagged releases but this doesn't work correctly I think, related to https://github.com/zerosnacks/foundry-bug-7225-repro - prioritizing #7225 to fix it properly