Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide unnecessary error on load error #679

Merged
merged 3 commits into from
Aug 30, 2024
Merged

fix: hide unnecessary error on load error #679

merged 3 commits into from
Aug 30, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Aug 30, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title. Hide compression error, magic mismatch error and checksum mismatch error with fn load().

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

fix #678

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx added the bug Something isn't working label Aug 30, 2024
@MrCroxx MrCroxx added this to the v0.11 milestone Aug 30, 2024
@MrCroxx MrCroxx self-assigned this Aug 30, 2024
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx enabled auto-merge (squash) August 30, 2024 04:44
@MrCroxx MrCroxx merged commit f2f80cf into main Aug 30, 2024
15 checks passed
@MrCroxx MrCroxx deleted the xx/hide branch August 30, 2024 04:51
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 63.33333% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-storage/src/large/generic.rs 47.36% 10 Missing ⚠️
foyer-storage/src/compress.rs 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
foyer-storage/src/error.rs 0.00% <ø> (ø)
foyer-storage/src/large/serde.rs 100.00% <100.00%> (ø)
foyer-storage/src/compress.rs 60.00% <0.00%> (ø)
foyer-storage/src/large/generic.rs 88.61% <47.36%> (-0.52%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug: unexpected exposure of magic mismatch error
1 participant